_Fake_copy_init
unification
#3041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Implicitly_convert_to
and_Fake_decay_copy
with_Fake_copy_init
.<type_traits>
,_Is_nothrow_convertible_v
isn't declaring any functions, so we don't need to suppress thevolatile
deprecation warnings about WG21-N4910 [depr.volatile.type]/3.<xstddef>
, we're just declaring_Fake_copy_init()
but not calling it, so we don't need to suppress truncation/sign-conversion warnings._Fake_copy_init()
returns_Ty
, unlike_Implicitly_convert_to
which returnedvoid
. There's a different warning number aboutvolatile
return types that we need to suppress.As mentioned in #1937's comments, this return type change from
void
to_Ty
has no other effects - the only usage outside ofnoexcept
is already usingvoid_t
:STL/stl/inc/type_traits
Line 1637 in 20db59e