-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<random>
: Improvements around static constexpr
member variables
#3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<random>
: Improvements around static constexpr
member variables
#3006
Conversation
even in C++14 mode.
Looks good, thanks! I hope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM; not marking request changes since I may get disagreement on the badness of ldexp_one
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for randomly hacking the codebase into a better state! ⌨️ 🖥️ 😻 |
This PR proposes the following improvements for some static member variables in
<random>
:_Swc_01_traits
will have all of its static member variables statically initialized.tr1
in C++17 (and later modes). They are deprecated in C++17, even though warnings seem to be silenced.The first should be reverted if changing from dynamic initialization to static one or removal of odr-using breaks ABI.