Skip to content

Implement LWG-3721: Allow an arg-id with a value of zero for width in std-format-spec #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2022
Merged

Implement LWG-3721: Allow an arg-id with a value of zero for width in std-format-spec #2906

merged 5 commits into from
Jul 28, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #2872.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner July 25, 2022 03:19
@frederick-vs-ja frederick-vs-ja mentioned this pull request Jul 25, 2022
Closed
26 tasks
@CaseyCarter CaseyCarter added LWG Library Working Group issue blocked Something is preventing work on this format C++20/23 format and removed blocked Something is preventing work on this labels Jul 25, 2022
@StephanTLavavej
Copy link
Member

Excellent, thank you! 😻

CaseyCarter
CaseyCarter approved these changes Jul 27, 2022
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Jul 27, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 028f92c into microsoft:main Jul 28, 2022
@frederick-vs-ja frederick-vs-ja deleted the lwg-3721 branch July 28, 2022 03:39
@StephanTLavavej
Copy link
Member

Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 😻 😻

fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@frederick-vs-ja @CaseyCarter @fsb4000
Implement LWG-3721: Allow an arg-id with a value of zero for width in…
1348b47 
… std-format-spec (microsoft#2906)

Co-authored-by: Casey Carter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
format C++20/23 format LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter