Skip to content

<yvals_core.h>: Update _MSVC_STL_UPDATE to July 2022 #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

<yvals_core.h>: Update _MSVC_STL_UPDATE to July 2022 #2840

merged 1 commit into from
Jul 12, 2022

Conversation

Alikhalesi
Copy link
Contributor

@Alikhalesi Alikhalesi commented Jul 2, 2022 •
edited
Loading

Resolves #2836

@Alikhalesi Alikhalesi requested a review from a team as a code owner July 2, 2022 03:36
@Alikhalesi Alikhalesi changed the title Resolves #2836 Update MSVC_STL_UPDATE to July 2022 Jul 2, 2022
@Alikhalesi Alikhalesi changed the title Update MSVC_STL_UPDATE to July 2022 <yvals_core.h>: Update _MSVC_STL_UPDATE to July 2022 Jul 2, 2022
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jul 2, 2022
fsb4000
fsb4000 approved these changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for your first contribution 🎉

strega-nil-ms
strega-nil-ms approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! ❤️

@StephanTLavavej StephanTLavavej self-assigned this Jul 9, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a4dc8a7 into microsoft:main Jul 12, 2022
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! This will ship in VS 2022 17.4 Preview 2. 🎉 😸 🚀

fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@Alikhalesi @fsb4000
<yvals_core.h>: Update _MSVC_STL_UPDATE to July 2022 (microsoft#2840)
d44dd3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@fsb4000 fsb4000 fsb4000 approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to July 2022
4 participants
@Alikhalesi @StephanTLavavej @fsb4000 @strega-nil-ms