Skip to content

<bit>: fix countl_zero on arm64 #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2022
Merged

<bit>: fix countl_zero on arm64 #2647

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e6c90a
Fix countl_zero on arm64 to properly subtract the zeros resulting fro…
Apr 11, 2022
0552a20
clang-format
Apr 11, 2022
5ef76e0
Remove unnecessary code (thanks AlexGuteniev).
StephanTLavavej Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/bit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,9 @@ _NODISCARD int _Checked_arm_arm64_countl_zero(const _Ty _Val) noexcept {
}
#else // ^^^ workaround / no workaround vvv
if constexpr (_Digits <= 32) {
return static_cast<int>(_CountLeadingZeros(_Val));
return static_cast<int>(_CountLeadingZeros(_Val)) - (numeric_limits<unsigned long>::digits - _Digits);
} else {
return static_cast<int>(_CountLeadingZeros64(_Val));
return static_cast<int>(_CountLeadingZeros64(_Val)) - (numeric_limits<unsigned long long>::digits - _Digits);
}
#endif // TRANSITION, GH-1586
}
Expand Down