Implement LWG-3525: uses_allocator_construction_args fails to handle types convertible to pair
#2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the resolution should be applied back to pre-C++20, so some implementation details are provided in all modes.
AlexGuteniev
reviewed
Apr 5, 2022
|
StephanTLavavej
approved these changes
Apr 21, 2022
This comment was marked as resolved.
This comment was marked as resolved.
raghavthind2005
approved these changes
Apr 21, 2022
CaseyCarter
approved these changes
Apr 27, 2022
CaseyCarter
approved these changes
Apr 28, 2022
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Apr 28, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this LWG issue resolution and improving the usability of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2551.
I also transform the resolution into C++17 and apply it to earlier modes. Because LWG-3525 fixes the wrong fix made by LWG-2975, which is clearly applicable to C++11~17.