Skip to content

Implement P2441R2 views::join_with #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 20, 2022
Merged

Implement P2441R2 views::join_with #2619

merged 15 commits into from
Jun 20, 2022

Conversation

cpplearner
Copy link
Contributor

This implements P2441R2 views::join_with.

Fixes #2538.

I need suggestions on test. This view depends on the category (input/forward/bidirectional), commonness, and element type of three ranges (outer, inner, pattern). Currently I simply copy the instantiation_test function from P0896R4_views_join, but it might be desirable to also test non-bidirectional_range or non-common_range patterns.

@cpplearner cpplearner requested a review from a team as a code owner March 28, 2022 08:38
miscco
miscco reviewed Mar 28, 2022
View reviewed changes
miscco
miscco reviewed Mar 28, 2022
View reviewed changes
miscco
miscco reviewed Mar 28, 2022
View reviewed changes
miscco
miscco reviewed Mar 28, 2022
View reviewed changes
cpplearner and others added 2 commits March 29, 2022 00:51
@cpplearner @miscco
Simplify _Category_base's template parameter list
c4435ae 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@cpplearner @miscco
Make _Variantish more generic
4a29f2b 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature labels Mar 28, 2022
@cpplearner @miscco
Use _Variantish in join_with_view
54e5a47 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@cpplearner

This comment was marked as resolved.

Sign in to view
miscco
miscco reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some question about the use of _Throw_bad_variant_access whether this is a valid use case here.

I would like to get some feedback on that

@CaseyCarter CaseyCarter self-assigned this Mar 30, 2022
StephanTLavavej
StephanTLavavej requested changes Apr 1, 2022
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
StephanTLavavej
StephanTLavavej reviewed Jun 14, 2022
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej
Copy link
Member

I've pushed a merge with main to resolve trivial adjacent-add conflicts in yvals_core.h and tests/std/test.lst.

@StephanTLavavej StephanTLavavej self-assigned this Jun 19, 2022
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo. Further changes can be pushed, but please notify me.

CaseyCarter
CaseyCarter approved these changes Jun 19, 2022
View reviewed changes
@CaseyCarter CaseyCarter removed their assignment Jun 19, 2022
@StephanTLavavej StephanTLavavej merged commit 34c9a73 into microsoft:main Jun 20, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++23 ranges feature! ✅ 😻 🎉

@cpplearner cpplearner deleted the join_with branch June 27, 2022 11:29
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@cpplearner @miscco
@StephanTLavavej @CaseyCarter @fsb4000
Implement P2441R2 views::join_with (microsoft#2619)
47ff24b 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
@achabense achabense mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2441R2 views::join_with
4 participants
@cpplearner @StephanTLavavej @CaseyCarter @miscco