Skip to content

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Feb 19, 2022

Resolves #2533

Internal use in mutex/condition_variable/node_handle - is fixed by creating a non-deprecated copy.

I'm not sure why we quote the deprecating paper, as we don't quote the WP merged papers elsewhere; but I followed the precedent.

⚠️ Expected merge conflict with #2061, take care of warning numbers.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner February 19, 2022 20:21
@AlexGuteniev

This comment was marked as resolved.

@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Feb 21, 2022
@StephanTLavavej StephanTLavavej self-assigned this Feb 23, 2022
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the non-deprecated copy is not needed, but I'm not sure.

# Conflicts:
#	tests/libcxx/expected_results.txt
#	tests/libcxx/skipped_tests.txt
#	tests/libcxx/usual_matrix.lst
fsb4000 added a commit to fsb4000/STL that referenced this pull request May 7, 2022
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I found only nitpicks, so I'll validate and push changes soon.

@StephanTLavavej StephanTLavavej removed their assignment May 12, 2022
@StephanTLavavej StephanTLavavej self-assigned this May 16, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request May 16, 2022
@StephanTLavavej StephanTLavavej merged commit cbd964d into microsoft:main May 17, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++23 feature and helping to modernize the ecosystem!

🧑‍🚀 🚀 🪐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1413R3 Deprecate aligned_storage And aligned_union
5 participants