Skip to content

updated _MSVC_STL_UPDATE #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

updated _MSVC_STL_UPDATE #2519

merged 1 commit into from
Feb 7, 2022

Conversation

ritik307
Copy link
Contributor

@ritik307 ritik307 commented Feb 4, 2022

Fixes #2515

@ritik307 ritik307 requested a review from a team as a code owner February 4, 2022 17:10
@ritik307
Copy link
Contributor Author

ritik307 commented Feb 4, 2022

Hi, @StephanTLavavej Made a PR. Kindly review 😊

@CaseyCarter CaseyCarter added the enhancement Something can be improved label Feb 4, 2022
@StephanTLavavej StephanTLavavej self-assigned this Feb 6, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@ritik307
Copy link
Contributor Author

ritik307 commented Feb 6, 2022

@StephanTLavavej Nothing to push 😊

@ddr533
Copy link
Contributor

ddr533 commented Feb 7, 2022

Excellent work!

@CaseyCarter CaseyCarter merged commit ee6a79e into microsoft:main Feb 7, 2022
@CaseyCarter
Copy link
Contributor

Thanks - and congratulations on your first STL change! 🎉🎉 😹 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+4 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@cpplearner cpplearner cpplearner approved these changes

@ddr533 ddr533 ddr533 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to February 2022
6 participants
@ritik307 @StephanTLavavej @ddr533 @CaseyCarter @fsb4000 @cpplearner