Clean up unnecessary (void) casts
#2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Oct 17, 2021
StephanTLavavej
approved these changes
Oct 18, 2021
|
Agreed. This is also consistent with previous commits (possibly before the GitHub era) - we originally had even more occurrences, and were able to reduce them as the compiler improved. |
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
|
Thanks for banishing these casts to the void! 🪄 😹 🎉 |
AZero13
pushed a commit
to AZero13/STL
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As DevCom-1004719 appears to be
fixedpartially fixed.Intentionally leaving the second of these occurrences, which is not fixed:
STL/stl/inc/variant
Lines 1478 to 1480 in 8833270