Skip to content

Misc untag dispatch #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Mar 19, 2022
Merged

Misc untag dispatch #2219

merged 34 commits into from
Mar 19, 2022
+109 −129

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner September 27, 2021 07:21
@AlexGuteniev AlexGuteniev changed the title Misc tag dispatch Misc untag dispatch Sep 27, 2021
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Sep 28, 2021
miscco
miscco approved these changes Sep 28, 2021
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Sep 29, 2021
miscco
miscco reviewed Oct 20, 2021
View reviewed changes
AlexGuteniev
AlexGuteniev commented Oct 20, 2021
View reviewed changes
AlexGuteniev
AlexGuteniev commented Oct 20, 2021
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@AlexGuteniev

This comment was marked as resolved.

Sign in to view
This was referenced Dec 5, 2021
Closed
Merged
AlexGuteniev added a commit to AlexGuteniev/STL that referenced this pull request Jan 13, 2022
@AlexGuteniev
Untag dispatch construct
0b58631 
Towards microsoft#189
Separated from microsoft#2219
@AlexGuteniev AlexGuteniev mentioned this pull request Jan 13, 2022
Merged
@AlexGuteniev AlexGuteniev mentioned this pull request Jan 16, 2022
Open
AlexGuteniev added a commit to AlexGuteniev/STL that referenced this pull request Jan 16, 2022
@AlexGuteniev
Untag dispatch regex
8440d1c 
Towards microsoft#189
Separated from microsoft#2219
@AlexGuteniev AlexGuteniev mentioned this pull request Jan 16, 2022
Merged
StephanTLavavej
StephanTLavavej reviewed Feb 19, 2022
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Feb 19, 2022
@StephanTLavavej
Copy link
Member

Thanks for eliminating more occurrences of tag dispatch! I went ahead and pushed changes for minor issues I noticed.

@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
CaseyCarter
CaseyCarter approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persnickety comment things that I'll just push corrections for in a moment.

@CaseyCarter CaseyCarter removed their assignment Mar 16, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 18, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d15bda2 into microsoft:main Mar 19, 2022
@StephanTLavavej
Copy link
Member

Thanks for these codebase simplifications and throughput improvements! 😻 🚀 😺

@AlexGuteniev AlexGuteniev deleted the tag_dispatch_2 branch March 19, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @miscco