Skip to content

cleared comment TRANSITION #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2021
Merged

cleared comment TRANSITION #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e9f81
cleared comment TRANSITION, GH-489
AnudeepGunukula Sep 3, 2021
737b11f
removed empty lines
AnudeepGunukula Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stl/inc/compare
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ struct compare_three_way_result<_Ty1, _Ty2> {

struct compare_three_way {
template <class _Ty1, class _Ty2>
requires three_way_comparable_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires three_way_comparable_with<_Ty1, _Ty2>
_NODISCARD constexpr auto operator()(_Ty1&& _Left, _Ty2&& _Right) const
noexcept(noexcept(_STD forward<_Ty1>(_Left) <=> _STD forward<_Ty2>(_Right))) /* strengthened */ {
return _STD forward<_Ty1>(_Left) <=> _STD forward<_Ty2>(_Right);
Expand Down
6 changes: 3 additions & 3 deletions stl/inc/functional
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,7 +2105,7 @@ namespace ranges {
struct not_equal_to {
// clang-format off
template <class _Ty1, class _Ty2>
requires equality_comparable_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires equality_comparable_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty1&&>(_Left) == static_cast<_Ty2&&>(_Right)))) /* strengthened */ {
return !static_cast<bool>(static_cast<_Ty1&&>(_Left) == static_cast<_Ty2&&>(_Right));
Expand All @@ -2118,7 +2118,7 @@ namespace ranges {
struct greater_equal {
// clang-format off
template <class _Ty1, class _Ty2>
requires totally_ordered_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires totally_ordered_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty1&&>(_Left) < static_cast<_Ty2&&>(_Right)))) /* strengthened */ {
return !static_cast<bool>(static_cast<_Ty1&&>(_Left) < static_cast<_Ty2&&>(_Right));
Expand All @@ -2131,7 +2131,7 @@ namespace ranges {
struct less_equal {
// clang-format off
template <class _Ty1, class _Ty2>
requires totally_ordered_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires totally_ordered_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty2&&>(_Right) < static_cast<_Ty1&&>(_Left)))) /* strengthened */ {
return !static_cast<bool>(static_cast<_Ty2&&>(_Right) < static_cast<_Ty1&&>(_Left));
Expand Down
4 changes: 0 additions & 4 deletions stl/inc/system_error
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ public:
}
#endif // !_HAS_CXX20

// TRANSITION, GH-489
#ifdef __cpp_lib_concepts
_NODISCARD strong_ordering operator<=>(const error_category& _Right) const noexcept {
return compare_three_way{}(_Addr, _Right._Addr);
Expand Down Expand Up @@ -181,7 +180,6 @@ public:
return _System_error_equal(_Left, _Right);
}

// TRANSITION, GH-489
#ifdef __cpp_lib_concepts
_NODISCARD friend strong_ordering operator<=>(const error_code& _Left, const error_code& _Right) noexcept {
if (const auto _Result = _Left.category() <=> _Right.category(); _Result != 0) {
Expand Down Expand Up @@ -267,7 +265,6 @@ public:
return _Left.category() == _Right.category() && _Left.value() == _Right.value();
}

// TRANSITION, GH-489
#ifdef __cpp_lib_concepts
_NODISCARD friend strong_ordering operator<=>(
const error_condition& _Left, const error_condition& _Right) noexcept {
Expand Down Expand Up @@ -321,7 +318,6 @@ _NODISCARD inline bool operator==(const error_condition& _Left, const error_cond
return _Left.category() == _Right.category() && _Left.value() == _Right.value();
}

// TRANSITION, GH-489
#ifdef __cpp_lib_concepts
_NODISCARD inline strong_ordering operator<=>(const error_code& _Left, const error_code& _Right) noexcept {
if (const auto _Result = _Left.category() <=> _Right.category(); _Result != 0) {
Expand Down
6 changes: 3 additions & 3 deletions stl/inc/xutility
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2969,7 +2969,7 @@ namespace ranges {
struct equal_to {
// clang-format off
template <class _Ty1, class _Ty2>
requires equality_comparable_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires equality_comparable_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty1&&>(_Left) == static_cast<_Ty2&&>(_Right)))) /* strengthened */ {
return static_cast<bool>(static_cast<_Ty1&&>(_Left) == static_cast<_Ty2&&>(_Right));
Expand All @@ -2982,7 +2982,7 @@ namespace ranges {
struct less {
// clang-format off
template <class _Ty1, class _Ty2>
requires totally_ordered_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires totally_ordered_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty1&&>(_Left) < static_cast<_Ty2&&>(_Right)))) /* strengthened */ {
return static_cast<bool>(static_cast<_Ty1&&>(_Left) < static_cast<_Ty2&&>(_Right));
Expand All @@ -2995,7 +2995,7 @@ namespace ranges {
struct greater {
// clang-format off
template <class _Ty1, class _Ty2>
requires totally_ordered_with<_Ty1, _Ty2> // TRANSITION, GH-489
requires totally_ordered_with<_Ty1, _Ty2>
_NODISCARD constexpr bool operator()(_Ty1&& _Left, _Ty2&& _Right) const noexcept(noexcept(
static_cast<bool>(static_cast<_Ty2&&>(_Right) < static_cast<_Ty1&&>(_Left)))) /* strengthened */ {
return static_cast<bool>(static_cast<_Ty2&&>(_Right) < static_cast<_Ty1&&>(_Left));
Expand Down