Skip to content

Various cleanups #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 27, 2021
Merged

Various cleanups #2140

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f8bd64f
Remove unused `__DOUBLE_EXPONENT_BITS`/`__FLOAT_EXPONENT_BITS`.
StephanTLavavej Jul 21, 2021
dbf1b0c
We can directly include Windows.h now.
StephanTLavavej Jul 22, 2021
b087a33
Change `typename CharT` to `class CharT`.
StephanTLavavej Jul 22, 2021
0297b19
Stylistically reorder exception_ptr operators; provide only necessary…
StephanTLavavej Jul 22, 2021
b9ea785
Construct tags with empty braces.
StephanTLavavej Aug 6, 2021
563714a
Capitalize template parameters.
StephanTLavavej Aug 6, 2021
0ed74f9
Change `size() == 0` to `empty()` for `string`s.
StephanTLavavej Aug 6, 2021
6575910
Remove unnecessary parens in `(b.func) (b.data)`.
StephanTLavavej Aug 6, 2021
51ea5ae
Avoid unnecessary `auto`.
StephanTLavavej Aug 6, 2021
3cb7042
libcxx: Unskip C++23 tests (will be "unsupported" until GH 2001 is fi…
StephanTLavavej Aug 16, 2021
ac95e58
Emit an error when compiling stdatomic.h as C.
StephanTLavavej Aug 18, 2021
2fa59f1
Simplify stoi(): int and long are the same size for us.
StephanTLavavej Aug 18, 2021
959faf0
Use deprecated attributes in experimental/coroutine (improves syntax …
StephanTLavavej Aug 18, 2021
a30b6ff
Demacroize xthreads.h size/alignment constants.
StephanTLavavej Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/string
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ _NODISCARD inline int stoi(const string& _Str, size_t* _Idx = nullptr, int _Base
_Xinvalid_argument("invalid stoi argument");
}

if (_Errno_ref == ERANGE || _Ans < INT_MIN || INT_MAX < _Ans) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break icc? I mean I don't care, but that may be why we checked this in the first place

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question (as we try to avoid gratuitous breaks). It shouldn't - the Intel C++ Compiler issues we've encountered have involved 80-bit long double (and occasionally new compiler intrinsics). AFAIK, there are no issues with our LLP64 assumption that sizeof(int) equals sizeof(long) equals 4 (that assumption is widespread throughout our codebase).

This was originally being checked because MSVC's STL was licensed from Dinkumware, where the upstream source code was portable to many platforms.

if (_Errno_ref == ERANGE) {
_Xout_of_range("stoi argument out of range");
}

Expand Down Expand Up @@ -276,7 +276,7 @@ _NODISCARD inline int stoi(const wstring& _Str, size_t* _Idx = nullptr, int _Bas
_Xinvalid_argument("invalid stoi argument");
}

if (_Errno_ref == ERANGE || _Ans < INT_MIN || INT_MAX < _Ans) {
if (_Errno_ref == ERANGE) {
_Xout_of_range("stoi argument out of range");
}

Expand Down