Remove constructible_from test case #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... that was invalidated by WG21-P1787 "Declarations and where to find them". This is the darkest shadowy corner of a test filled with corner cases, and as such I don't feel it's worth the trouble of tracking which compiler front ends have correct behavior and which not. Fixes VSO-1357053/AB#1357053.
StephanTLavavej
requested changes
Aug 9, 2021
StephanTLavavej
approved these changes
Aug 9, 2021
mnatsuhara
approved these changes
Aug 13, 2021
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
|
Thanks for de-squirrelifying this test coverage! 🐿️ ⛔ 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that was invalidated by WG21-P1787 "Declarations and where to find them". This is the darkest shadowy corner of a test filled with corner cases, and as such I don't feel it's worth the trouble of tracking which compiler front ends have correct behavior and which not.
Fixes VSO-1357053/AB#1357053.