Implement rest of P2259R1, Repairing Input Range Adaptors #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
timsong-cpp
reviewed
Jul 16, 2021
CaseyCarter
reviewed
Jul 16, 2021
Co-authored-by: Casey Carter <[email protected]>
miscco
force-pushed
the
P2259-iterator-fixes
branch
from
02955d9 to
30b155d
Compare
CaseyCarter
suggested changes
Aug 3, 2021
| @@ -4020,18 +4018,20 @@ namespace ranges { | |||
| template <bool _Const> | |||
| class _Sentinel; | |||
|
|
|||
| template <class _Traits> // TRANSITION, LWG-3289 | |||
| template <class _Base> | |||
There was a problem hiding this comment.
Note to other reviewers: we already implement the equivalent of the split_view changes from P2259R1.
| #ifdef __cpp_lib_concepts | ||
| using reference = iter_rvalue_reference_t<_Iter>; | ||
| using iterator_concept = input_iterator_tag; | ||
| using reference = iter_rvalue_reference_t<_Iter>; | ||
| #else // ^^^ __cpp_lib_concepts / !__cpp_lib_concepts vvv | ||
| using reference = | ||
| conditional_t<is_reference_v<_Iter_ref_t<_Iter>>, remove_reference_t<_Iter_ref_t<_Iter>>&&, _Iter_ref_t<_Iter>>; |
There was a problem hiding this comment.
Note to reviewers: #1939 already implemented the counted_iterator changes from P2259R1.
... which has been resolved as NAD after adoption of P2259. Drive-by: Correctly order the `iterator_traits` nested types in three places where they are misordered. (There's some value in using the Standard's consistent ordering.)
... by adding constructors and giving up on the code generation benefits of being ABI-aggregate. Adding a defaulted `<=>` to the partial specializations of the base class `_Ioterator_category_base` allows us to go back to defaulting `==` and `<=>`.
... that I made redundant in the last commit.
CaseyCarter
approved these changes
Aug 12, 2021
StephanTLavavej
requested changes
Aug 12, 2021
... even in stateless classes for which `<=>` is a constant function.
CaseyCarter
approved these changes
Aug 13, 2021
StephanTLavavej
requested changes
Aug 13, 2021
StephanTLavavej
approved these changes
Aug 13, 2021
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
|
Thanks for implementing these repairs for broken Standardese! 🏚️ 🛠️ 🏡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not add new test yet, will audit them
Fixes #1684.