-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement P2210R2 Superior String Splitting #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement P2210R2 Superior String Splitting #2042
Conversation
57ef4a1
to
f0ac30c
Compare
f0ac30c
to
1fae222
Compare
Co-authored-by: Adam Bucior <[email protected]>
d3101f4
to
7e9e444
Compare
@miscco - Are you still working on resolving @timsong-cpp's comments, or were they resolved in the recent commits? Just wondering whether this should move to Initial Review again. 😺 |
Actually this is something that I would want to get @CaseyCarter's opinion on. As far as I remember his analysis was that we do not need to do anything related to P2281 and if we change something here I would want to be sure we change it consistently everywhere |
Co-authored-by: Casey Carter <[email protected]>
@CaseyCarter I would also suggest to move this to a follow up. As far as I can tell there are two things we need to do
Given that those are non trivial changes (and I currently do not have that much capacity for delicate tasks) I feel it is better to extract them into a follow up. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll push changes to address my feedback (they were all localized).
Thanks a lot for the review and the fixes 😸 |
I'm mirroring this to an MSVC-internal PR - please notify me if any further changes are pushed. |
|
This implements the first part of P2210R2 renaming
split_view
tolazy_split_view
Works towards #1980.