Don't rely on MSVC/Clang bugs in ranges test machinery #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDG reported that `basic_common_reference<T, U>` is ambiguous when both `T` and `U` are specializations of `test::proxy_reference`, as occurs in `P0896R4_ranges_alg_equal`. Apparently both MSVC and Clang share the same bug here and pick a specialization to make this work. I've verified that `cl /BE` compiles `P0896R4_ranges_alg_equal` successfully with this change (by temporarily hacking `concepts_20_matrix.lst` and `yvals_core.h`).
This comment has been minimized.
This comment has been minimized.
barcharcraz
approved these changes
Jun 21, 2021
StephanTLavavej
approved these changes
Jun 21, 2021
|
Thanks for investigating and fixing this! It's always amusing to see independently-developed compilers end up with the same bugs. 😹 🪲 🪲 |
|
For posterity: the corresponding MSVC bug is VSO-1343148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDG reported that
basic_common_reference<T, U>is ambiguous when bothTandUare specializations oftest::proxy_reference, as occurs inP0896R4_ranges_alg_equal. Apparently both MSVC and Clang share the same bug here (See LLVM-50723) and pick a specialization to make this work.I've verified that
cl /BEcompilesP0896R4_ranges_alg_equalsuccessfully with this change (by temporarily hackingconcepts_20_matrix.lstandyvals_core.h).