Skip to content

implement P1951R1: Default Template Arguments For pair's Forwarding Constructor #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 30, 2021
Merged

implement P1951R1: Default Template Arguments For pair's Forwarding Constructor #2009

merged 10 commits into from
Jul 30, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jun 13, 2021

Fixes #1976

@fsb4000 fsb4000 requested a review from a team as a code owner June 13, 2021 14:56
@fsb4000 fsb4000 changed the title implement P1951R1 implement P1951R1: Default Template Arguments For pair's Forwarding Constructor Jun 13, 2021
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jun 14, 2021
CaseyCarter
CaseyCarter reviewed Jun 22, 2021
View reviewed changes
@fsb4000 fsb4000 requested a review from CaseyCarter June 23, 2021 12:11
CaseyCarter
CaseyCarter approved these changes Jun 23, 2021
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Jun 23, 2021
@StephanTLavavej

This comment has been minimized.

Sign in to view
StephanTLavavej
StephanTLavavej reviewed Jul 28, 2021
View reviewed changes
@StephanTLavavej
Copy link
Member

FYI @CaseyCarter, I pushed changes after you approved, to guard this feature for C++23 (due to the breaking change impact and our usual conventions; we guard even innocuous stuff like shared_ptr::weak_type when doing so is easy). Note that C++23 implies _HAS_CONDITIONAL_EXPLICIT, so now only that branch is being changed.

@StephanTLavavej StephanTLavavej merged commit 7b59dff into microsoft:main Jul 30, 2021
@fsb4000 fsb4000 deleted the fix1976 branch July 30, 2021 02:58
@StephanTLavavej
Copy link
Member

Thanks for implementing this new feature in one of C++'s most popular types! 😺 🚀 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@SuperWig SuperWig SuperWig left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P1951R1 Default Template Arguments For pair's Forwarding Constructor
5 participants
@fsb4000 @StephanTLavavej @CaseyCarter @SuperWig @timsong-cpp