Skip to content

Implement LWG-3548 shared_ptr construction from unique_ptr should move (not copy) the deleter #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2021
Merged

Implement LWG-3548 shared_ptr construction from unique_ptr should move (not copy) the deleter #2007

merged 2 commits into from
Jun 29, 2021
+10 −1

Conversation

AdamBucior
Copy link
Contributor

No description provided.

@AdamBucior AdamBucior requested a review from a team as a code owner June 13, 2021 12:05
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Jun 14, 2021
@StephanTLavavej
Copy link
Member

Thanks! I agree that forward is appropriate outside of a perfect forwarding context here (this also occurs in pair and tuple when a type might be a reference).

I found a convenient place to add test coverage - we had a fancy-pointer deleter that was being used to construct a unique_ptr that was then moved into a shared_ptr with no other usage, so we can make that deleter movable-only and ensure that this behavior is never damaged by future maintenance.

@CaseyCarter CaseyCarter mentioned this pull request Jun 23, 2021
Closed
36 tasks
@CaseyCarter CaseyCarter removed their assignment Jun 24, 2021
@StephanTLavavej StephanTLavavej self-assigned this Jun 24, 2021
@StephanTLavavej StephanTLavavej merged commit 8a6585a into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for improving everyone's favorite smart pointers! 🧠 😸

@AdamBucior AdamBucior deleted the lwg3548 branch June 29, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamBucior @StephanTLavavej @CaseyCarter