Fix OpenApiEncoding explode property serialization #2508
Merged
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kammerjaeger
force-pushed
the
fix/explode-default-value
branch
from
f6c558d to
c14dd24
Compare
|
@kammerjaeger can you please also sign the CLA? (see the bot comment) |
|
@microsoft-github-policy-service agree company="AMD" |
|
Thanks for the fast review. How often do you release new versions? |
|
We make releases as needed, as long as it's possible because this is a maintenance branch. Once we release main, I'll re-run it manually, please ping me if I forget :) |
|
@kammerjaeger I had to trigger the release manually to circumvent the the issue, I'm waiting for somebody to approve it #2513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Explode serialization is wrong when style is "form"
This fixes the same problem as #544 but for OpenApiEncoding.
The spec describes different behavior depending on if it is set or not (see: https://spec.openapis.org/oas/v3.1.0.html#fixed-fields-12) and also different defaults depending on the style value.
This also needs to be cherry picked to main, I just need it for v1 but will create a pr to main with the change if this pr is fine.
Please let me know what you think.