Skip to content

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1922

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review November 20, 2024 09:48
Name = tag?.Name ?? Name;
Description = tag?.Description ?? Description;
ExternalDocs = tag?.ExternalDocs != null ? new(tag?.ExternalDocs) : null;
ExternalDocs = tag?.ExternalDocs != null ? new(tag.ExternalDocs) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MaggieKimani1 MaggieKimani1 merged commit 7556ba5 into vnext Dec 17, 2024
8 of 9 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-tags-serialization branch December 17, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization of Tags is not working correctly
2 participants