[Memory Leak] Only release header handle if producev returned no errors #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrieucNx
changed the title
|
Hey when are you guys releasing this? this is not available on any of the conan center recipes, thanks. |
|
Just released this https://github.com/mfontanini/cppkafka/releases/tag/v0.4.1. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak that happens when the
rd_kafka_producevfunction returns an error. This is due to the fact that the function itself takes a pointer to the header struct and takes ownership of it only if no error occurs. If the function returns something else thatRD_KAFKA_RESP_ERR_NO_ERRORthen the ownership ofheadersis not taken.This patch passes the pointer of the header to the produce function and only release the ownership of the memory if the function returned an non error error code.