Skip to content

Conversation

BrodaNoel
Copy link
Collaborator

The real name is São Tomé and Príncipe.

Sao Tome and Principe has missing some punctuations

@BrodaNoel BrodaNoel changed the title Update countries.json Fix São Tomé and Príncipe Apr 13, 2024
@BrodaNoel
Copy link
Collaborator Author

I think we may have to consider replacing the "special characters" in the includes.

It would be nice to just add Sao Tome and Principe in the countries.json, but then if the user searches for São Tomé and Príncipe, it finds it.

Something similar should happens with the & and the and.
Some people may search for Sao Tome & Principe

@meeDamian
Copy link
Owner

Good idea!

One question however: If a country has diacritics in its official name, in this example let's say Türkiye, then what should be the output of name("🇹🇷")?

  1. Türkiye - assuming everyone has appropriate font available, or
  2. Turkey - for sake of backwards compatibility?

@BrodaNoel
Copy link
Collaborator Author

I would return Türkiye, and deploy a new breaking version of this library.

meeDamian added a commit that referenced this pull request Aug 29, 2024
@meeDamian
Copy link
Owner

According to https://www.iso.org/obp/ui/#iso:code:3166:ST, the official name doesn't include diacritics.

@BrodaNoel
Copy link
Collaborator Author

True, oficial name does not includes it, but, Google Places API includes it, and also the oficial language on Wikipedia https://pt.wikipedia.org/wiki/S%C3%A3o_Tom%C3%A9_e_Pr%C3%ADncipe

And check this: https://www2.camara.leg.br/saotomeeprincipe/constituicao/constituicao-da-republica-democratica-de-s.tome-e#a1
That's the constitution of São Tomé and Príncipe. The constitution includes it.

I don't know... Just in case, I would add it to improve the experience in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants