Skip to content

Conversation

TristanWebber
Copy link

  1. Created an example demonstrating how to manually add a board with SX126x transceiver. This also has the benefit of showing how to override methods in the HalConfiguration_t more generally.
  2. Updated HOWTO-Manually-Configure.md to describe the HalConfiguration_t methods introduced for the SX126x transceivers
  3. Updated README.md to introduce the new example

@terrillmoore
Copy link
Member

Thanks! I'll try to review and merge tonight or tomorrow.

@terrillmoore
Copy link
Member

I've reviewed. I'll merge it onto head, however please note:

  1. the change log in README.md has not been updated
  2. we've not updated the version number in the header file or in library.properties -- even though we'vd not changed anything in the core libarary, the arduino infrastructure basically requires a version bump. It can be a patch version, since core function is not changing.
  3. we don't have any regression tests to check that the example compiles

I'll try to do this, but I guess I'll need to open a related ticket to track it.

@terrillmoore terrillmoore merged commit 01a880f into mcci-catena:master Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants