Invalid condition when checking the chip mode?

[Maddocrus]

Describe the bug
Hello plz check this:
..\MCCI LoRaWAN LMIC library\src\lmic\radio_sx126x.c
line 209 :

// ----------------------------------------
// GetStatus        **  Chapter 13 GetStatus
#define SX126x_GETSTATUS_CHIPMODE_MASK 0x07 // Bits 6:4
#define SX126x_CHIPMODE_STDBY_RC       0x02
#define SX126x_CHIPMODE_STDBY_XOSC     0x03
#define SX126x_CHIPMODE_FS             0x04
#define SX126x_CHIPMODE_RX             0x05
#define SX126x_CHIPMODE_TX             0x06

..\MCCI LoRaWAN LMIC library\src\lmic\radio_sx126x.c
Problem here that will always TRUE->
Line 1160:

   // Sleep needs to be entered from standby_RC mode 
     if ((getStatus() | SX126x_GETSTATUS_CHIPMODE_MASK) != SX126x_CHIPMODE_STDBY_RC) {
        setStandby(STDBY_RC);
    }
    setSleep(0);
    return 1;

Environment

• CPU STM32f103
• Radio SX1262

Expected behavior

Normally, the response is 0x22 and I expect that the code will not turn on the one that is already active every time.

Screenshots

Additional context

This condition occurs several times.

[terrillmoore]

Your analysis looks correct. What happens if you patch this to:

if ((getStatus() & SX126x_GETSTATUS_CHIPMODE_MASK) != SX126x_CHIPMODE_STDBY_RC) {

Do problems get better or worse?

We may have to involve the contributor of the SX126x code, Tristan Webber, to take a look.

[Maddocrus]

I have corrected to the option you suggested and shifted the macro definitions

// ----------------------------------------
// GetStatus        **  Chapter 13 GetStatus
#define SX126x_GETSTATUS_CHIPMODE_MASK 0x70 // Bits 6:4
#define SX126x_CHIPMODE_STDBY_RC       0x20
#define SX126x_CHIPMODE_STDBY_XOSC     0x30
#define SX126x_CHIPMODE_FS             0x40
#define SX126x_CHIPMODE_RX             0x50
#define SX126x_CHIPMODE_TX             0x60
   
if ((getStatus() & SX126x_GETSTATUS_CHIPMODE_MASK) != SX126x_CHIPMODE_STDBY_RC) {

since there is a comment on GetStatus:
..\MCCI LoRaWAN LMIC library\src\lmic\radio_sx126x.c
Line 733:

// Chapter 13.5: Communication Status Information

// Chip mode is (getStatus | 0x70)
static u1_t getStatus(void) {
    u1_t status;
    lmic_hal_spi_read_sx126x(GetStatus, NULL, 0, &status, 1);
    return status;
}

Thank you for help, you can close the issue.