MSC4163: Make ACLs apply to EDUs #4163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Ahouansou <[email protected]>
tulir
added
proposal
x86pup
reviewed
Jul 7, 2024
tulir
reviewed
Jul 7, 2024
There was a problem hiding this comment.
Implementation requirements:
- Server
There was a problem hiding this comment.
See server implementations in thread @ https://github.com/matrix-org/matrix-spec-proposals/pull/4163/files#r1667727322
…stead considering the origin to the event in practice this doesn't make a significant difference, due to the fact that servers should already be rejecting EDUs from servers which are not the same as the server of the user ID to prevent impersonation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I think this is pretty straightforward, has an implementation in conduwuit and makes sense from what ACLs are meant to do. @mscbot fcp merge |
|
Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people: Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
proposed-final-comment-period
turt2live
approved these changes
Jul 10, 2024
|
@mscbot concern general clarity |
mscbot
added
the
unresolved-concerns
anoadragon453
approved these changes
Jul 17, 2024
turt2live
reviewed
Jul 23, 2024
mscbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
turt2live
removed
the
needs-implementation
|
I haven't verified the implementation on this, but presumably someone has if it was accepted back in August. |
|
They do work, it was initially added to conduwuit as part of a moderation need and confirmed it stopped the problem since then. |
3 tasks
|
Spec PR: matrix-org/matrix-spec#2004 |
tulir
added
spec-pr-in-review
|
merged! |
richvdh
added
merged
26 tasks
43 tasks
3 tasks
13 tasks
erooke
added a commit
to erooke/nixpkgs
that referenced
this pull request
Aug 15, 2025
Dendrite 0.15.0 is a security release supporting [room version 12](https://matrix.org/blog/2025/08/security-release/). It also added support for [MSC4163](matrix-org/matrix-spec-proposals#4163) and [MSC3967](matrix-org/matrix-spec-proposals#3967). Dendrite 0.15.1 is a bug fix release on top of that. Full details can be found on dendrite's [changelog](https://github.com/element-hq/dendrite/blob/main/CHANGES.md).
erooke
added a commit
to erooke/nixpkgs
that referenced
this pull request
Aug 15, 2025
Dendrite 0.15.0 is a security release supporting [room version 12](https://matrix.org/blog/2025/08/security-release/). It also added support for [MSC4163](matrix-org/matrix-spec-proposals#4163) and [MSC3967](matrix-org/matrix-spec-proposals#3967). Dendrite 0.15.1 and 2 are a bug fix releases on top of that. Full details can be found on dendrite's [changelog](https://github.com/element-hq/dendrite/blob/main/CHANGES.md).
nixpkgs-ci bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Aug 17, 2025
Dendrite 0.15.0 is a security release supporting [room version 12](https://matrix.org/blog/2025/08/security-release/). It also added support for [MSC4163](matrix-org/matrix-spec-proposals#4163) and [MSC3967](matrix-org/matrix-spec-proposals#3967). Dendrite 0.15.1 and 2 are a bug fix releases on top of that. Full details can be found on dendrite's [changelog](https://github.com/element-hq/dendrite/blob/main/CHANGES.md). (cherry picked from commit ebcdb9c)
MultisampledNight
pushed a commit
to MultisampledNight/nixpkgs
that referenced
this pull request
Aug 20, 2025
Dendrite 0.15.0 is a security release supporting [room version 12](https://matrix.org/blog/2025/08/security-release/). It also added support for [MSC4163](matrix-org/matrix-spec-proposals#4163) and [MSC3967](matrix-org/matrix-spec-proposals#3967). Dendrite 0.15.1 and 2 are a bug fix releases on top of that. Full details can be found on dendrite's [changelog](https://github.com/element-hq/dendrite/blob/main/CHANGES.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
Signed-off-by: Matthias Ahouansou [email protected]
FCP tickyboxes