MSC3959: Sliding Sync Extension: Account Data #3959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
proposal
| tokens and SHOULD be omitted when the client already has these events. | ||
|
|
||
|
|
||
| ## Potential issues |
There was a problem hiding this comment.
I'd like to make this MSC aware of MSC3391, which adds deletion of account data, and changes/adds the semantics of it.
In the current iteration, it means that receiving {} is interpreted as "deleted" (in a delta response), and that in every initial response, the client should replace all known keys from before with just the keys and data present in the new response.
This semantic change would also potentially interfere with any efforts to deduplicate account data across non-delta-ing sliding sync.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Client Impl
Server Impl