chore(ui): room_list_service::Room::latest_event no longer uses SlidingSyncRoom (+ drop SlidingSyncRoomExt)
#3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oom` in `room_list::Room`. This patch updates `matrix_sdk_ui::room_list::Room::latest_event` to fetch the latest event from `matrix_sdk::Room` instead of `matrix_sdk::sliding_sync::SlidingSyncRoom`. It removes one dependency to `SlidingSyncRoom` and it simplifies the code.
Hywan
changed the title
room_list_service::Room::latest_event no longer uses SlidingSyncRoom (+ drop SlidingSyncRoomExt)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3540 +/- ##
==========================================
- Coverage 83.84% 83.82% -0.02%
==========================================
Files 254 253 -1
Lines 25842 25843 +1
==========================================
- Hits 21668 21664 -4
- Misses 4174 4179 +5 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Jun 13, 2024
This patch removes the `matrix_sdk_ui::timeline::SlidingSyncRoomExt` trait as it's no longer necessary since `room_list::Room::latest_event` no longer uses `SlidingSyncRoom` to fetch the latest event.
Hywan
force-pushed
the
fix-ui-roomlist-latest-event
branch
from
1fa6a4a to
6d12894
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is twofold:
matrix_sdk_ui::room_list_service::Room::latest_eventto fetch the latest event frommatrix_sdk::Roominstead ofmatrix_sdk::sliding_sync::SlidingSyncRoom. It removes one dependency toSlidingSyncRoomand it simplifies the code.matrix_sdk_ui::timeline::SlidingSyncRoomExttrait 🎉.SlidingSyncRoomtech debt #3079