Add parseCallNotificationContent #5015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo K <[email protected]>
Half-Shot
reviewed
Sep 19, 2025
Signed-off-by: Timo K <[email protected]>
BillCarsonFr
requested changes
Sep 19, 2025
src/matrixrtc/types.ts
Outdated
| * @returns a parsed IRTCNotificationContent | ||
| */ | ||
| export function parseCallNotificationContent(content: IContent): IRTCNotificationContent { | ||
| if (!content["m.mentions"]) { |
There was a problem hiding this comment.
so this is expected to at least be an empty [] array? cannot be skipped? I think ruma skips it if it is not set
There was a problem hiding this comment.
I think it also might already do checks on this in the notifier. Lets only check for it to be an obj here.
src/matrixrtc/types.ts
Outdated
| throw new Error("Missing or invalid lifetime"); | ||
| } | ||
|
|
||
| if (content["decline_reason"] && typeof content["decline_reason"] !== "string") { |
There was a problem hiding this comment.
This is new to me, a decline_reason in a RTCNotificationContent?
There was a problem hiding this comment.
you are right this is legacy... Not there anymore. its from the time where we used the notification event as the decline as well. This should have been done in the PR that added the decline event type...
Signed-off-by: Timo K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to cap the lifetime of the m.rtc.notification event. It makes sense to combine this with a method that also validates all the fields of the event.
parseCallNotificationContentdoes the validation and tha cap.Signed-off-by: Timo K [email protected]
Checklist
public/exportedsymbols have accurate TSDoc documentation.