-
-
Notifications
You must be signed in to change notification settings - Fork 640
Implement experimental encrypted state events. #4994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please don't put words like "feat" in titles of matrix-js-sdk PRs: such titles end up the changelog, and although implementing this has indeed been quite a feat, it doesn't do to brag about it ;) (also https://richvdh.org/conventional-commits-considered-harmful.html but that's beside the point) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - a few smallish points to work through together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks!
@kaylendog the "downstream" checks failed, meaning when we compile Element Web with this change something went wrong. The error is:
(From https://github.com/matrix-org/matrix-js-sdk/actions/runs/17948535831/job/51041145148 , accessed via the "Details" link above.) I think this is a valid error: your new property should definitely be optional, so events from clients that don't support it still work ok. |
All fixed! |
Awesome, please rebase and force-push and I'll merge |
Signed-off-by: Skye Elliot <[email protected]>
e31d7cb
to
b880897
Compare
Adds support for MSC3414-esque encrypted state events.
matrix-sdk-crypto-wasm
to15.3.0
which includes support for encrypting state events.MatrixClient.enableEncryptedStateEvents
flag to configure top-level behaviour.MatrixClient.sendStateEvent
to call into the WASM SDK if encryption is enabled.MatrixEvent.getWireStateKey
, analagous toMatrixEvent.getWireContent
.This can be split into multiple PRs for ease of reviewing if required!
Checklist
public
/exported
symbols have accurate TSDoc documentation.