Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Apr 4, 2023

GMSL is intended for Federation only. Sister PR to matrix-org/gomatrixserverlib#357

@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 4, 2023
@kegsay kegsay requested a review from a team as a code owner April 4, 2023 16:25
@kegsay kegsay changed the title Move GMSL cllient types to Dendrite Move GMSL client types to Dendrite Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 77.84% and no project coverage change.

Comparison is base (985298c) 66.75% compared to head (d10c369) 66.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3045   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files         495      497    +2     
  Lines       53548    53633   +85     
=======================================
+ Hits        35746    35804   +58     
- Misses      14203    14229   +26     
- Partials     3599     3600    +1     
Flag Coverage Δ
unittests 46.36% <77.84%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
roomserver/api/query.go 0.00% <ø> (ø)
syncapi/routing/filter.go 36.48% <0.00%> (-2.71%) ⬇️
syncapi/routing/getevent.go 44.68% <0.00%> (-2.13%) ⬇️
syncapi/routing/relations.go 56.71% <0.00%> (-4.48%) ⬇️
syncapi/storage/postgres/account_data_table.go 83.92% <ø> (ø)
...ncapi/storage/postgres/current_room_state_table.go 71.04% <ø> (ø)
syncapi/storage/postgres/filter_table.go 60.86% <ø> (ø)
...ncapi/storage/postgres/output_room_events_table.go 74.22% <ø> (ø)
syncapi/storage/postgres/presence_table.go 75.00% <ø> (ø)
syncapi/storage/sqlite3/account_data_table.go 82.08% <ø> (ø)
... and 29 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kegsay kegsay enabled auto-merge (squash) April 4, 2023 17:06
@kegsay kegsay merged commit 3691423 into main Apr 4, 2023
@kegsay kegsay deleted the kegan/gmsl-client-types branch April 4, 2023 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants