Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Apr 4, 2023

partly takes care of #2870 by making sure that rule IDs don't start with a dot.

@S7evinK S7evinK added C-Client-API tests Issues related to tests. Missing/Flakey/etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Apr 4, 2023
@S7evinK S7evinK requested a review from a team as a code owner April 4, 2023 11:07
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 82.75% and project coverage change: +0.02 🎉

Comparison is base (94e81cc) 66.62% compared to head (cb9f94e) 66.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   66.62%   66.65%   +0.02%     
==========================================
  Files         495      497       +2     
  Lines       53625    53621       -4     
==========================================
+ Hits        35729    35739      +10     
- Misses      14257    14303      +46     
+ Partials     3639     3579      -60     
Flag Coverage Δ
unittests 46.84% <82.75%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
userapi/api/api.go 70.90% <ø> (ø)
clientapi/routing/pushrules.go 79.03% <78.94%> (+15.87%) ⬆️
userapi/internal/user_api.go 63.12% <85.71%> (+0.41%) ⬆️
internal/pushrules/validate.go 100.00% <100.00%> (ø)

... and 97 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kegsay kegsay merged commit c45d8cd into main Apr 14, 2023
@kegsay kegsay deleted the s7evink/pushrulestests branch April 14, 2023 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Client-API T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants