Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 30, 2023

When trying to join a room in short sequence, it is possible that a state reset occurs.

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Mar 30, 2023
@S7evinK S7evinK requested a review from a team as a code owner March 30, 2023 12:39
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 56.25% and project coverage change: -0.18 ⚠️

Comparison is base (f956a8c) 66.38% compared to head (781b38f) 66.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3040      +/-   ##
==========================================
- Coverage   66.38%   66.21%   -0.18%     
==========================================
  Files         499      501       +2     
  Lines       53799    57587    +3788     
==========================================
+ Hits        35715    38129    +2414     
- Misses      14533    15739    +1206     
- Partials     3551     3719     +168     
Flag Coverage Δ
unittests 49.98% <56.25%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clientapi/routing/routing.go 61.72% <56.25%> (-2.40%) ⬇️

... and 195 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs comments.

@S7evinK S7evinK requested a review from kegsay April 19, 2023 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants