Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 24, 2023

Contains a breaking change, since the endpoints /_dendrite/admin/evacuateRoom/{roomID} and /_dendrite/admin/evacuateUser/{userID} are now using POST instead of GET

@S7evinK S7evinK added tests Issues related to tests. Missing/Flakey/etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Mar 24, 2023
@S7evinK S7evinK requested a review from a team as a code owner March 24, 2023 11:25
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.30 🎉

Comparison is base (234ed60) 65.41% compared to head (4de5c2f) 65.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
+ Coverage   65.41%   65.72%   +0.30%     
==========================================
  Files         495      495              
  Lines       53623    53606      -17     
==========================================
+ Hits        35078    35233     +155     
+ Misses      14894    14705     -189     
- Partials     3651     3668      +17     
Flag Coverage Δ
unittests 43.66% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clientapi/routing/admin.go 60.92% <100.00%> (+30.72%) ⬆️
clientapi/routing/routing.go 58.07% <100.00%> (+0.86%) ⬆️
roomserver/internal/perform/perform_admin.go 28.39% <100.00%> (+18.42%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking due to it going from GET -> POST, but that is fine. Please mark it as such in this PR / merge commit so we remember though!

@S7evinK S7evinK merged commit fa77103 into main Mar 27, 2023
@S7evinK S7evinK deleted the s7evink/admintests branch March 27, 2023 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. tests Issues related to tests. Missing/Flakey/etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants