Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 23, 2023

Doesn't buy us much, but makes everything a bit more consistent.

Also removes the SQL trace driver, as it is unused and the output is hard to read anyway.

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Mar 23, 2023
@S7evinK S7evinK requested a review from a team as a code owner March 23, 2023 11:20
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.42 🎉

Comparison is base (cb18ba0) 63.15% compared to head (52347c0) 63.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   63.15%   63.57%   +0.42%     
==========================================
  Files         497      497              
  Lines       53822    53685     -137     
==========================================
+ Hits        33993    34132     +139     
+ Misses      16134    15946     -188     
+ Partials     3695     3607      -88     
Flag Coverage Δ
unittests 43.19% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/sqlutil/sqlite_cgo.go 100.00% <ø> (+50.00%) ⬆️
internal/sqlutil/sqlite_native.go 66.66% <ø> (+12.12%) ⬆️
internal/sqlutil/sqlutil.go 76.92% <ø> (+5.49%) ⬆️
internal/sqlutil/writer_exclusive.go 74.28% <ø> (+9.28%) ⬆️
federationapi/storage/postgres/blacklist_table.go 83.78% <100.00%> (+24.69%) ⬆️
...derationapi/storage/postgres/joined_hosts_table.go 65.11% <100.00%> (+16.63%) ⬆️
.../storage/postgres/notary_server_keys_json_table.go 78.57% <100.00%> (+18.57%) ⬆️
...rage/postgres/notary_server_keys_metadata_table.go 63.33% <100.00%> (+16.95%) ⬆️
federationapi/storage/postgres/queue_json_table.go 70.00% <100.00%> (+16.66%) ⬆️
federationapi/storage/postgres/queue_pdus_table.go 65.21% <100.00%> (+15.21%) ⬆️
... and 17 more

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK changed the title Move every db.Prepare to sqlutil.Statementlist Move every db.Prepare to sqlutil.Statementlist, remove trace driver Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants