This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Add /search tests
#3025
Merged
Add /search tests
#3025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
tests
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
==========================================
+ Coverage 63.15% 63.84% +0.68%
==========================================
Files 497 497
Lines 53822 54125 +303
==========================================
+ Hits 33993 34555 +562
+ Misses 16134 15904 -230
+ Partials 3695 3666 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kegsay
suggested changes
Mar 23, 2023
| name: "searchTerm specified", | ||
| wantOK: true, | ||
| searchReq: SearchRequest{ | ||
| SearchCategories: SearchCategories{RoomEvents: RoomEvents{SearchTerm: "hello"}}, |
There was a problem hiding this comment.
Can it do partial matches like hell? Can we also check that it isn't just doing prefix matching by searching for world3? Does it strip punctuation?
kegsay
approved these changes
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.