Skip to content

Conversation

husanu
Copy link

@husanu husanu commented Jun 12, 2015

Generate the correct list of channels where the user is in (for
commands: QUIT, NICK and KILL)

Generate the correct list of channels where the user is in (for
commands: QUIT, NICK and KILL)
@Throne3d
Copy link

Throne3d commented Apr 5, 2017

I've encountered the same issue (with 0.5.2) and want to register that I'd appreciate this being merged.

(Reproduction of the issue, if that's the problem:)

With the following event handlers:

this.ircClient.on('join', (channel, nick) => {
  console.log(`received join event with params: "${channel}", "${nick}"`);
  // other handling …
});

this.ircClient.on('part', (channel, nick, reason) => {
  console.log(`received part event with params: "${channel}", "${nick}", "${reason}"`);
  // other handling…
});

this.ircClient.on('quit', (nick, reason, channels) => {
  console.log(`received quit event with params: "${nick}", "${reason}", [${String(channels)}]`);
  // other handling…
});

this.ircClient.on('names', (channel, nicks) => {
  console.log(`received names event with params: "${channel}",`, nicks);
  // other handling…
});

I then take the steps:

  1. Have the bot join the IRC server and connect to #testbed and #testbed2
  2. Connect to #testbed with a second client
  3. Disconnect from the server with the second client
5 Apr 21:29:03 - SEND: JOIN #testbed
received join event with params: "#testbed", "test2"
received names event with params: "#testbed", { test2: '@' }
5 Apr 21:29:03 - SEND: JOIN #testbed2
received join event with params: "#testbed2", "test2"
received names event with params: "#testbed2", { test2: '@' }
5 Apr 21:29:04 - SEND: MODE #testbed
5 Apr 21:29:04 - SEND: MODE #testbed2
received join event with params: "#testbed", "Throne"
5 Apr 21:29:18 - QUIT: [email protected] Quit: Leaving
received quit event with params: "Throne", "Quit: Leaving", [#testbed,#testbed2]

i.e. it sends to all the channels the bot is in, not just all the channels the user has been seen in.

It seems like incorrect behavior for the quit event to include all channels the bot is in, when the user was not in all such channels.

@husanu husanu closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants