Skip to content

Conversation

sruenwg
Copy link
Contributor

@sruenwg sruenwg commented May 2, 2025

Closes #1102
Closes #724

This changes the expression syntax documented on the Expressions page to follow the patterns proposed in #1102.
Some incorrectly documented syntaxes were fixed in the process.

match before:
image
match after:
image

in before:
image
in after:
image

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (b4d8978) to head (6d12492).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files         115      115           
  Lines        4935     4935           
  Branches     1403     1403           
=======================================
  Hits         4623     4623           
  Misses        312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM
Copy link
Collaborator

HarelM commented May 3, 2025

Thanks for this great effort!
I've added a few comments, nothing major.
Once addressed, I'll merge this.

@sruenwg
Copy link
Contributor Author

sruenwg commented May 4, 2025

Thanks for the comments @HarelM!
Please check the updated version + my comments whenever you are able to, thanks again 🙇

@HarelM
Copy link
Collaborator

HarelM commented May 4, 2025

Just to be on the safe side, although this doesn't change the logic, let's add a changelog entry if anyone is relaying on the current v8 content.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!!!

@HarelM HarelM merged commit f57a1d9 into maplibre:main May 5, 2025
6 checks passed
@sruenwg sruenwg deleted the docs-expression-syntax branch May 5, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step syntax can include colors
3 participants