global-state expression support in filter and paint properties #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigniewmatysek-tomtom
changed the title
…obal-state-expression
HarelM
reviewed
Apr 28, 2025
HarelM
reviewed
Apr 28, 2025
4 tasks
|
Can you resolve conflicts please? I'll merge this afterwards. |
|
Ok, one last question: are |
…obal-state-expression
…libre-gl-js into global-state-expression
|
@HarelM I ensured both methods have 100% coverage:
|
HarelM
approved these changes
May 20, 2025
hiddewie
added a commit
to hiddewie/OpenRailwayMap-vector
that referenced
this pull request
Jun 4, 2025
See https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.6.0 This includes maplibre/maplibre-gl-js#5613 allowing for global map state (like theme and date). Uses maplibre/maplibre-style-spec#1044, maplibre/maplibre-style-spec#886, maplibre/maplibre-gl-js#4964.
hiddewie
added a commit
to hiddewie/OpenRailwayMap-vector
that referenced
this pull request
Jun 4, 2025
See https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.6.0 This includes maplibre/maplibre-gl-js#5613 allowing for global map state (like theme and date). Uses maplibre/maplibre-style-spec#1044, maplibre/maplibre-style-spec#886, maplibre/maplibre-gl-js#4964. Changes: replace `date` with a global state property, to simplify map rendering and dynamic date changes.
melitele
pushed a commit
to mapwhit/tilerenderer
that referenced
this pull request
Jul 28, 2025
melitele
pushed a commit
to mapwhit/tilerenderer
that referenced
this pull request
Jul 29, 2025
melitele
pushed a commit
to mapwhit/tilerenderer
that referenced
this pull request
Jul 30, 2025
maplibre/maplibre-gl-js#5613 - adds a new map methods: `setGlobalStateProperty` and `getGlobalState` - `global-state` expression won't work in layout properties (`setGlobalStateProperty` will have no effect on those)
melitele
pushed a commit
to mapwhit/tilerenderer
that referenced
this pull request
Jul 30, 2025
maplibre/maplibre-gl-js#5613 - adds a new map methods: `setGlobalStateProperty` and `getGlobalState` - `global-state` expression won't work in layout properties (`setGlobalStateProperty` will have no effect on those)
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 1, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 1, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
8 tasks
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 2, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
8 tasks
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 6, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 8, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Aug 8, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
HarelM
pushed a commit
that referenced
this pull request
Aug 9, 2025
* add unit tests checking that sources are reloaded only when necessary on changes of global state rferenced by layout properties * `global-state` expression support in layout properties complements `global-state` expression support in filter and paint properties #5613 * changelog --------- Co-authored-by: Natalia Kowalczyk <[email protected]>
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Sep 5, 2025
complements `global-state` expression support in filter and paint properties maplibre#5613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new map methods:
setGlobalStateProperty()andgetGlobalState()leveraging the newglobal-stateexpression.Out of the scope:
global-expressionin layout properties (setGlobalStateProperty()will have no effect on those).See the style spec update (needs to be merged first) and related issues:
maplibre/maplibre-style-spec#886
#4964
See example:
Launch Checklist
CHANGELOG.mdunder the## mainsection.