disconnect named pipe after read #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolitze
force-pushed
the
non-blocking-named-pipe
branch
from
f6bd530 to
1298187
Compare
|
I think the changes are fine. Just nitpicking:
Thanks! |
|
Thanks for the feedback. Absolutely understandable. The spaces slipped me through. Line endings are leaving me baffled... I see them all CRLF in this file both on main and on my branch. I would need a little help what line to look at. |
|
@mame just being curious if you could help with further feedback or merge this? Thank you! |
|
Sorry I am late, thank you! |
|
And I have released v0.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome project! This really saved my day!
I was looking for a simple way to share ssh-agents on WSL2 for a while now. Works perfectly for the ssh-agent shipped with Windows.
Some minor issues occurred when using the application with KeeAgent (https://github.com/dlech/KeeAgent, for getting ssh keys from KeePass) and/or the gpg-agent (for getting ssh keys from hardware tokens e.g. Nitrokey3). Both ssh-agent implementations seem not to like that the named pipe is kept open and will not allow connections from other ssh-clients (e.g. ssh on Windows) while wsl2-ssh-agent is running in WSL.
I had two different ideas of solving this:
My proposal is doing the latter to save the overhead of spawning the PowerShell process on every request. It is a bit of a hack in waiting for a 0 byte read to open the named pipe. I hope you still find this change acceptable.