Incorrect free_shipping flag for virtual products

[gexxx05]

Preconditions and environment

• Magento version 2.4.7-p4

Steps to reproduce

1. Create two virtual products (test1, test2) and make them buyable in storefront.
2. Create a cart price rule for free shipping, add skus from created products and select "For matching items only" in dropdown.
   
3. Go to test1 product detail page and add it to cart with qty 1.
4. Check field applied_rule_ids for item test1 in quote_item table (should have the id of the sales rule created in step 2)
5. Check field free_shipping for item test1 in quote_item table (should be 1).
6. Go to test2 product detail page and add it to cart with qty 1.
7. Check field applied_rule_ids for item test2 in quote_item table (should have the id of the sales rule created in step 2)
8. Check field free_shipping for item test2 in quote_item table (should be 1 but is 0).
   

Expected result

free_shipping should be 1 for item test2, because the sale rule was applied correctly.

Actual result

free_shipping is 0 for item test2, even if the sale rule was applied correctly.

Additional information

The issue is in method isFreeShipping in file vendor\magento\module-offline-shipping\Model\Quote\Address\FreeShipping.php. If you add a virtual product to the cart, free_shipping is set for both addresses (shipping and billing) to 1:

$shippingAddress->setFreeShipping((int)$result);
$this->applyToItems($items, $result);

If you add another virtual product to the cart, the billing address already has free_shipping set to 1, which breaks the loop:

$this->calculator->processFreeShipping($item);
// at least one item matches to the rule and the rule mode is not a strict
if ((bool)$item->getAddress()->getFreeShipping()) {
    $result = true;
    break;
}

This is because only the shipping address is reset before the loop:

$shippingAddress = $quote->getShippingAddress();
$shippingAddress->setFreeShipping(0);

If we reset the billing address before the loop as well, everything works fine andthe free_shipping flag is correct for every quote_item:

$shippingAddress = $quote->getShippingAddress();
$shippingAddress->setFreeShipping(0);
$billingAddress = $quote->getBillingAddress();
$billingAddress ->setFreeShipping(0);

Perhaps someone thought that the free_shipping flag is irrelevant for virtual products. However, if you rely on this, as we do in one of our custom modules, this behaviour is incorrect.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @gexxx05. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @gexxx05 ,

Thank you for your report and collaboration.

We attempted to reproduce the issue in our latest version 2.4 develop but were unable to do so.

We followed these steps and did not encounter any issues. Could you please recheck once and let us know if we are missing any steps to reproduce this issue?

Therefore, we are marking this ticket as "Issue: Needs Update".

Thank you!

[gexxx05]

@magento I am working on this

[m2-assistant]

Hi @gexxx05! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[gexxx05]

@magento add to contributors team

[m2-assistant]

Hi @gexxx05! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.