Skip to content

getFunction() ignoring receiver on imports #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2024
Merged

getFunction() ignoring receiver on imports #509

merged 1 commit into from
Nov 24, 2024

Conversation

na4ma4
Copy link
Contributor

@na4ma4 na4ma4 commented Jun 11, 2024

getFunction() ignores the receiver, selecting the first matching function name regardless of scope.

Fixes #508

@na4ma4 na4ma4 mentioned this pull request Aug 26, 2024
Closed
@perrito666
Copy link
Contributor

@na4ma4 sorry for the extreme lag responding to this, I had to build some time to work on floss in my calendar.

Would it be possible to add a test like your example from #508 into this PR? this way we ensure we do not regress and/or hit other corners.

@perrito666 perrito666 self-requested a review November 24, 2024 14:30
perrito666
perrito666 approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@perrito666 perrito666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill submit a test for this

perrito666 added a commit to perrito666/mage that referenced this pull request Nov 24, 2024
@perrito666
This adds a test to bug 508
7fe0717 
It fails against master before merging the patch on magefile#509 (review)
@perrito666 perrito666 mentioned this pull request Nov 24, 2024
Merged
@perrito666 perrito666 merged commit 0800736 into magefile:master Nov 24, 2024
natefinch pushed a commit that referenced this pull request Nov 24, 2024
@perrito666
This adds a test to bug 508 (#516)
32e0107 
* This adds a test to bug 508

It fails against master before merging the patch on #509 (review)
@na4ma4
Copy link
Contributor Author

na4ma4 commented Nov 25, 2024

Thanks, it was on my to-do list but hadn't had time yet :)

@perrito666
Copy link
Contributor

My pleasure @na4ma4 , I had some time on my hands and I felt it was the least I could do after taking months to review your fix :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrito666 perrito666 perrito666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: using Default with imports selects first matching func by name
2 participants
@na4ma4 @perrito666