Cherry-pick to master: [sw,signing] Enforce hash length for pre-hashed SHA256 #28363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![lowrisc-ci[bot]](https://avatars.githubusercontent.com/in/923580?s=60&v=4){kind=small}
The SPHINCS+ key generation and signing functions expect a 32-byte message when the `PreHashedSha256` domain parameter is used. Enforce this length constraint with an assertion. Change-Id: I416b4bb58434ae7880786f795c0dd7bcdf41e514 Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit 8a07c40)
lowrisc-ci
bot
requested review from
cfrantz
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #28229 to branch
master.