[i2c,testutils] Move i2c testutils to DT API #28318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
moidx,
pamaury,
sameo,
davidschrammel,
AlexJones0 and
jwnrt
and removed request for
a team and
moidx
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
i2c-testutils-dt
branch
from
cc11277 to
b59ddca
Compare
|
There seems to be an issue with the csrng, where there is one dep. |
pamaury
reviewed
Sep 22, 2025
| dt_periph_io_t sda_periph_io = dt_i2c_periph_io(i2c_dt, kDtI2cPeriphIoSda); | ||
| dt_periph_io_t scl_periph_io = dt_i2c_periph_io(i2c_dt, kDtI2cPeriphIoScl); | ||
|
|
||
| // Disconnect SDA and SCL inputs by connecting to constant zero |
There was a problem hiding this comment.
The comment says constant zero but the code says constant one.
pamaury
reviewed
Sep 22, 2025
|
|
||
| // Disconnect SDA and SCL inputs by connecting to constant zero | ||
| TRY(pinmux_testutils_connect(pinmux, sda_periph_io, kDtPeriphIoDirIn, | ||
| kDtPeriphIoConstantOne)); |
There was a problem hiding this comment.
Here you need a pad but apparently I did not create not create the "constant 0" and "constant 1" pads in the DT. I think what you need to modify the dt_api.h template to add:
/* Pad that is constantly tied to one (input only) */
extern const dt_periph_io_t kDtPadConstantZero;
/* Pad that is constantly tied to zero (input only) */
extern const dt_periph_io_t kDtPadConstantOne;and in dt_api.c:
/* Pin that is constantly tied to zero (input/output) */
const dt_pad_t kDtPadConstantZero = {
.__internal = {
.type = kDtPadTypeMio,
.mio_out_or_direct_pad = 0,
.insel = kTopEarlgreyPinmuxInselConstantZero, // Here need one line of python to make that top generic
}
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the I2C testutils to the DT API to support generic tops. The same approach was used as in the UART testutils conversion.
Depends on #28316