Skip to content

Conversation

hcallahan-lowrisc
Copy link
Contributor

Instantiate this new piece of testbench machinery in the top_earlgrey testbench, leaving it connected but as of yet, unused.

This is in preparation for full simulations of manuf / provisioning stages using binaries built for the 'silicon_creator' exec_env, which do not use the backdoor software logger and make heavy use of the spi_console for data transfer during test execution.

Review commit-by-commit, but the first commit is the bulk of this changeset.

@hcallahan-lowrisc hcallahan-lowrisc requested a review from a team as a code owner September 8, 2025 15:27
@hcallahan-lowrisc hcallahan-lowrisc added the Component:DV DV issue: testbench, test case, etc. label Sep 8, 2025
@hcallahan-lowrisc hcallahan-lowrisc requested a review from a team as a code owner September 8, 2025 15:27
@hcallahan-lowrisc hcallahan-lowrisc added TOP:earlgrey CherryPick:master This PR should be cherry-picked to master labels Sep 8, 2025
@hcallahan-lowrisc hcallahan-lowrisc requested review from marnovandermaas and pamaury and removed request for a team September 8, 2025 15:27
@hcallahan-lowrisc hcallahan-lowrisc force-pushed the dev_ottf_spi_console branch 2 times, most recently from f0c2417 to e26aab4 Compare September 8, 2025 16:10
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really enjoyed reading this: it's very clear and enjoyable to go through. I've left quite a few small comments (crikey! more than I thought!), but they are all small things: it's really nice code!

…ctions

See header comments in ottf_spi_console_pkg.sv for more details.

Signed-off-by: Harry Callahan <[email protected]>
@hcallahan-lowrisc
Copy link
Contributor Author

In moving the class to it's own file, the diff from the last push is mostly useless for reviewing the feedback changes. Sorry!

@timothytrippel timothytrippel merged commit aae256c into lowRISC:earlgrey_1.0.0 Sep 24, 2025
64 of 66 checks passed
@lowrisc-ci
Copy link

lowrisc-ci bot commented Sep 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:master This PR should be cherry-picked to master Component:DV DV issue: testbench, test case, etc. TOP:earlgrey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants