Support both, encoded and non encoded api-key formats on plugin configuration #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcams
force-pushed
the
17360-support-opaque-api-key
branch
from
11c27d6 to
574ec87
Compare
donoghuc
reviewed
Sep 15, 2025
robbavey
requested changes
Sep 15, 2025
alexcams
force-pushed
the
17360-support-opaque-api-key
branch
from
574ec87 to
c2a9f32
Compare
donoghuc
reviewed
Sep 16, 2025
donoghuc
reviewed
Sep 16, 2025
donoghuc
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Thanks for doing the refactor to make those internal methods actually private! This looks good. I see you added a section in the changelog (and proposed a patch release version there). We can follow up on all the steps to push a release separately. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid double-encoding opaque Elasticsearch API keys.
Previously, API keys that were already in encoded format were incorrectly re-encoded, causing connection failures. This update ensures that only raw keys are encoded, supporting both opaque and
id:api-keyformats without issue.Closes #1222