feat(react): allow specifying multiple device kinds in MediaDeviceMenu props #1208
Conversation
This is an update to the MediaDeviceMenu react component to allow specifying device kinds as an array (e.g. microphone + speaker). - The menu already rendered a multi-kind menu when no kind was specified, there was just no way to specify >1 kind to render when specifying a kind. This PR leverages that same rendering. - This should be API-compatible. The one type-change was that the existing `MediaDeviceMenuProps` interface which is now a type alias for the prior props interface (now renamed `MediaDeviceMenuPropsSingleKind`) and the new `MediaDeviceMenuPropsMultiKind` props interface. - If you want any changes, feel free to ask, just wanted to see if this was directionally aligned with something you might accept. Signed-off-by: Scott Willeke <[email protected]>
|
|
|
|
I see that the api-check failed. If you can confirm (1) that you're open to this contribution and (2) how you'd like to handle that, happy to refine this to meet your needs. |
|
thanks for the PR! This makes sense as an addition. The API check fails as the exposed type is being changed, but as you correctly stated, the new type is backwards compatible, so I don't see any issue in adding this in. You'll have to run |
feat(react): allow specifying multiple device kinds in MediaDeviceMenu props
This is an update to the MediaDeviceMenu react component to allow specifying an array of device kinds instead of a single kind.
MediaDeviceMenuPropsinterface which is now a type alias for the prior props interface (now renamedMediaDeviceMenuPropsSingleKind) and the newMediaDeviceMenuPropsMultiKindprops interface.We're already using this in our app, and thought we'd share with the community. If something needs adjusted for you to accept let me know!