bugfix error matching sweeper #10189
Open
+11,112
−24,468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mod
Outdated
|
|
||
| retract v0.0.2 | ||
|
|
||
| replace github.com/btcsuite/btcwallet => github.com/ziggie1984/btcwallet v0.16.10-0.20250902074924-f9f0dabe6fbd |
There was a problem hiding this comment.
I lack experience with this in lnd, but are we ok with merging replaces to local forks to lnd master?
Roasbeef
requested changes
Sep 2, 2025
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
fcb4fba to
78c6696
Compare
ViktorTigerstrom
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Awesome, thanks for the changes 🎉! LGTM, though I'm lacking the context of @Roasbeef, so not sure if #10189 (comment) should be addressed.
ziggie1984
force-pushed
the
fix-fee-estimation
branch
2 times, most recently
from
0b7074c to
5661ca3
Compare
|
Verified on LITD and this approach fixes the bug ! |
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
5661ca3 to
2bc22ad
Compare
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
2bc22ad to
9d87bef
Compare
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
9d87bef to
7bc293c
Compare
|
Because of the new btcwallet grpc dependency 1.73 I also had to update the gprc lib for LND, that's why so many files are changed, all of them are auto-generated. |
ziggie1984
force-pushed
the
fix-fee-estimation
branch
2 times, most recently
from
5a3da30 to
28f81c3
Compare
Roasbeef
requested changes
Sep 10, 2025
We can now handle tool dependencies directly with the go tool directive rather than using the extra tools.go pattern.
The previous update of the go tool increase dependencies so that the kvdb module with the kvdb_etcd flag set was not able to build. We update the etcd dependant libraries so that the build succeeds. Update dependencies so that we can build the kvdb module with the kvdb_etcd build tag which becomes important when upgrading to the new v2 golangci-lint linter.
run make rpc and update all the autogenerated gprc golang files.
We update the hash to the most recent master hash because the new v2 linter reports legacy issues and changed its behaviour and we want to avoid fixing older issues.
Because of the previous update of etcd dependant libraries we also need to make sure we update the etcd libraries in the main module as well otherwise the cross compiling will fail.
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
28f81c3 to
038a1fb
Compare
When overlay channels are used the extra output needs to be considered.
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
038a1fb to
219245c
Compare
|
Linter failing after update: |
Roasbeef
reviewed
Sep 13, 2025
| }, | ||
| 1, // heightHint | ||
| 0, // csvDelay (no CSV requirement) | ||
| locktime, // cltvExpiry |
There was a problem hiding this comment.
Can remove these inline comments.
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| // Call the function under test. |
There was a problem hiding this comment.
Superflous comments here in the test body.
| // user can intervene and increase the size of his mempool or increase | ||
| // his min relay fee configuration. | ||
| case errors.Is(err, chain.ErrMempoolMinFeeNotMet), | ||
| errors.Is(err, chain.ErrMinRelayFeeNotMet): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
btcsuite/btcwallet#1053
Fixes:
lightninglabs/taproot-assets#1770
and
lightninglabs/lightning-terminal#1139 (which needs to bump the corresponding LND version if this is merged.)
!!!ATTENTION!!! First 9 commits belong to #10209 !!!ATTENTION!!!