[SDL2] Fixed crash if joystick functions are passed a NULL joystick #9234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular this affects the doomsday game engine if no joystick or gamepad is attached. (cherry picked from commit 0dfdf1f) [smcv: Also included minor adjustment from libsdl-org#9233]
|
Please also apply to 2.30.x if accepted; it should apply cleanly there. |
|
Merged and cherry-picked to release-2.30.x, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this affects the doomsday game engine if no joystick or gamepad is attached.
(cherry picked from commit 0dfdf1f)
[smcv: Also included minor adjustment from #9233]
Backport from SDL3, with #9233 also included. This fixes a crash in the doomsday game engine: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1062969