Skip to content

Fix setting RGB without a player led #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Fix setting RGB without a player led #13524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f923a6
Fix setting RGB without a player led
antheas Aug 1, 2025
6387f78
Update src/joystick/hidapi/SDL_hidapi_sinput.c
slouken Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/joystick/hidapi/SDL_hidapi_sinput.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,7 @@ static bool HIDAPI_DriverSInput_SetJoystickLED(SDL_HIDAPI_Device *device, SDL_Jo
{
SDL_DriverSInput_Context *ctx = (SDL_DriverSInput_Context *)device->context;

if (ctx->player_leds_supported) {

// Set player number, finalizing the setup
if (ctx->joystick_rgb_supported) {
Uint8 joystickRGBCommand[SINPUT_DEVICE_REPORT_COMMAND_SIZE] = { SINPUT_DEVICE_REPORT_ID_OUTPUT_CMDDAT, SINPUT_DEVICE_COMMAND_JOYSTICKRGB, red, green, blue };
int joystickRGBBytesWritten = SDL_hid_write(device->dev, joystickRGBCommand, SINPUT_DEVICE_REPORT_COMMAND_SIZE);

Expand Down